Use index .Env for the optional tap and bucket tokens - #50
Merged
Conversation
The Homebrew cask and Scoop manifest stanzas gated their token and skip_upload on envOrDefault, which is a sprig function GoReleaser does not define, so a real release aborted with 'function envOrDefault not defined' the moment it reached the publish phase. goreleaser check does not evaluate templates, so the gate slipped through until a tagged run. Switch to index .Env "NAME", the idiom GoReleaser documents for an optional variable: it yields the token when the secret is set (push the update) and an empty string when it is not (skip_upload stays true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Homebrew cask and Scoop manifest stanzas gated their token and skip_upload on envOrDefault, a sprig function GoReleaser does not define. A real tagged release aborted with 'function envOrDefault not defined' at the publish phase. goreleaser check does not evaluate templates, so this slipped past the check gate until v0.3.1 / v0.3.7 / v0.2.3 were cut.
index .Env "NAME" is the idiom GoReleaser documents for an optional variable: it returns the token when the secret is set (push the update) and an empty string when it is not (skip_upload stays true).