removed useless regex characters escape - #721
Open
exeba wants to merge 2 commits into
Open
Conversation
krisu5
added a commit
to aegis-icons/aegis-icons.github.io
that referenced
this pull request
Jan 28, 2022
jamesadney
added a commit
to hfa3/list.js
that referenced
this pull request
Feb 7, 2022
The search code used to use 'string'.search which takes regex input. Now it used indexOf, so escaping is unnecessary and causes search to break after on of the special characters is entered. From: javve#721
|
Would like to +1 this PR. Fixing search is important to our use of list.js. |
|
I would also like to +1 this request. Seems a shame to leave an important feature broken if the work has already been done to fix it. |
|
Another +1. Wanted to use this library, but immediately encountered this problem. This has been neglected for over a year, so... I guess this project is dead? |
|
+1 for this request |
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 11, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 11, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 11, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 11, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above.
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 11, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above. Futher detail: Prior to v2.3.0, the search used regexp, so special chars had to be escaped. However version 2.3.0 implemented a new, faster search which didn't use regexp. Therefore by continuing to escape special chars, it's not possible to search for them. This defunct 'replace' function should be removed
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 12, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above. Futher detail: Prior to v2.3.0, the search used regexp, so special chars had to be escaped. However version 2.3.0 implemented a new, faster search which didn't use regexp. Therefore by continuing to escape special chars, it's not possible to search for them. This defunct 'replace' function should be removed
jonnydh
added a commit
to hmrc/catalogue-frontend
that referenced
this pull request
Aug 12, 2022
This bug was introduced in List.js:2.3.0, and a fix has been proposed which has not yet been merged: javve/list.js#721 This commit uses the proposed fix above. Futher detail: Prior to v2.3.0, the search used regexp, so special chars had to be escaped. However version 2.3.0 implemented a new, faster search which didn't use regexp. Therefore by continuing to escape special chars, it's not possible to search for them. This defunct 'replace' function should be removed
|
+1 for the request. The project looks dead to me? Then better to find an alternative. |
|
@javve : any chance this can be merged, or the author can be added as a contributor ? That would fix a bug in SQLPage (and many other dependent projects, I guess) |
|
If anyone needs to depend on a package on npm with the fix, I published: https://www.npmjs.com/package/list.js-fixed |
|
+1 Same issue there. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
==========================================
- Coverage 93.54% 93.54% -0.01%
==========================================
Files 19 19
Lines 837 836 -1
Branches 199 199
==========================================
- Hits 783 782 -1
Misses 38 38
Partials 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699