Use new DatePicker in WTForms date/time fields - #6832
Merged
Conversation
tomasr8
reviewed
Apr 3, 2025
tomasr8
left a comment
Member
There was a problem hiding this comment.
The icon alignment/size seems a bit off in the cloning dialog:
Compare with the material package form:
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 3, 2025 13:03
91ac181 to
b123e74
Compare
ThiefMaster
commented
Apr 3, 2025
| } | ||
| } | ||
|
|
||
| .ui-widget ind-date-picker > button { |
Member
Author
There was a problem hiding this comment.
@foxbunny Do you see a better solution for this? Making the rule inside %text-size-reset important would also work, but not sure if this doesn't have some bad side effects elsewhere...
Collaborator
There was a problem hiding this comment.
%text-size-reset is probably not the best workaround for the font size issue. It's more like a marker so I know what to address once we actually solve the problem (god knows when, lol). In theory, it shouldn't have any bad side-effects, but it can fail to work when, say, there are rules with high-specificity selectors that affect elements inside the widget and override font sizes.
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 3, 2025 14:46
b0c64ca to
c7cb8dc
Compare
ThiefMaster
marked this pull request as ready for review
April 3, 2025 15:13
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 3, 2025 15:56
5186647 to
f1d66af
Compare
- Adjust styling for the date picker custom element - Add attributes to date picker controls so they can be targeted in external CSS - Fix button accessibility in the WTFDateField component
This broke manually typing something to change the date
This reverts commit 83813e9.
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 4, 2025 09:44
f1d66af to
0ca0928
Compare
tomasr8
approved these changes
Apr 4, 2025
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 4, 2025 12:06
f4354f3 to
3dde667
Compare
tomasr8
approved these changes
Apr 4, 2025
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 7, 2025 10:06
536af06 to
0a4d6ef
Compare
ThiefMaster
force-pushed
the
wtf-date-picker
branch
from
April 7, 2025 12:10
0a4d6ef to
e8519e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6662