Skip to content

Fix issue with select/combobox on iOS Safari - #6839

Merged
ThiefMaster merged 4 commits into
indico:masterfrom
foxbunny:safari-combo-fix
May 16, 2025
Merged

Fix issue with select/combobox on iOS Safari#6839
ThiefMaster merged 4 commits into
indico:masterfrom
foxbunny:safari-combo-fix

Conversation

@foxbunny

@foxbunny foxbunny commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator
  • Fix unresponsive selection by tap
  • Fix buggy positioning logic

See additional notes in positioning.js for more details on how the fix works.

Fixes #6830

@foxbunny
foxbunny requested a review from ThiefMaster April 7, 2025 05:32
@foxbunny
foxbunny force-pushed the safari-combo-fix branch 3 times, most recently from bc554c5 to 601d74a Compare April 7, 2025 05:45
Comment thread indico/web/client/js/custom_elements/ind_combobox.js Outdated
@ThiefMaster

Copy link
Copy Markdown
Member

Seems to work fine as far as I can tell on the iPad we have here! Only slightly weird thing I noticed is that the open dropdown only repositions itself when you scroll until you finished scrolling... not sure how often people actually scroll the page w/ a dropdown open though.

@foxbunny

foxbunny commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator Author

Yeah, I couldn't find a workaround for that. The elastic scroll isn't taken into account when the browser reports scrollY.

@ThiefMaster

Copy link
Copy Markdown
Member

My colleague with an iphone tested this and the country field works now, but in single-choice registration fields it often simply doesn't select an option when tapping it in the dropdown

@foxbunny

foxbunny commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator Author

Could you please ask them what version of iOS they're on? I've specifically fixed that on the BrowserStack iPad...

@ThiefMaster

ThiefMaster commented Apr 9, 2025

Copy link
Copy Markdown
Member

@micsucmed ^

FWIW on the iPad we have here it also did not happen, but for @GovernmentPlates this also happened on the emulator (emulated iphone, not ipad)

@ThiefMaster

Copy link
Copy Markdown
Member

At least his UA string was "Mozilla/5.0 (iPhone; CPU iPhone OS 18_3_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.3.1 Mobile/15E148 Safari/604.1"

@micsucmed

Copy link
Copy Markdown
Contributor

My phone is using iOS 18.3.2

@foxbunny

foxbunny commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks

foxbunny and others added 4 commits May 16, 2025 11:26
- Fix unresponsive selection by tap
- Fix buggy positioning logic

See additional notes in positioning.js for more details on how the fix
works.

Fixes indico#6830
Also adds a remote logger for emergency use
It may be useful, but does not belong in this PR
@ThiefMaster
ThiefMaster merged commit 0dcc644 into indico:master May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FinalDropDown is not usable on iOS

3 participants