Preserve date when switching mode in RB DateNavigator - #6817
Merged
Conversation
tomasr8
commented
Mar 24, 2025
GovernmentPlates
approved these changes
Mar 26, 2025
Currently, when changing e.g. from the day mode to a week mode, the date changes as well. If the date is in the middle of the week and we select the 'week' mode, the date is changed to the start date of the week. This means that for example selecting 'day' -> 'week' -> 'day' will not return to the same date which is surprising. This PR makes it so that the date does not change when the view changes. This means that 'day' -> 'week' -> 'day' returns to the same date.
ThiefMaster
force-pushed
the
rb-keep-day
branch
from
March 26, 2025 09:05
66ebd43 to
a5dd602
Compare
ThiefMaster
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context in INC4379609
This is the component in question (e.g. on
/rooms/calendar):Currently, when changing e.g. from the day mode to a week mode, the date changes as well. If the date is in the middle of the week and we select the 'week' mode, the date is changed to the start date of the week.
This means that for example selecting 'day' ->
'week' -> 'day' will not return to the same date which is surprising.
This PR makes it so that the date does not change when the view changes. This means that 'day' -> 'week' -> 'day' returns to the same date.