chore: upgrade v1.17 - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
This PR upgrades the
github.com/goravel/frameworkdependency to a newer version and updates the setup script to use renamed API methods.Key changes:
v1.16.1-0.20260130094642tov1.16.1-0.20260202061217ingo.modmodify.AddProviderApply()tomodify.RegisterProvider()in setup/setup.go:49modify.RemoveProviderApply()tomodify.UnregisterProvider()in setup/setup.go:78The changes are consistent with a framework API refactor where method names have been improved for clarity. The functionality remains the same - these methods handle service provider registration/unregistration when using bootstrap setup mode.
Confidence Score: 5/5
AddProviderApply→RegisterProvider,RemoveProviderApply→UnregisterProvider) are semantically equivalent with improved naming. No logic changes or new functionality introduced.Important Files Changed
github.com/goravel/frameworkfrom versionv1.16.1-0.20260130094642-7135899a236etov1.16.1-0.20260202061217-60e5444dde33to pull in latest framework changesgithub.com/goravel/frameworkversionAddProviderApplytoRegisterProviderandRemoveProviderApplytoUnregisterProviderfor bootstrap setup modeSequence Diagram
sequenceDiagram participant User participant ArtisanCLI as Artisan CLI participant Setup as setup/setup.go participant Modify as modify package participant Bootstrap as bootstrap/providers.go participant App as config/app.go User->>ArtisanCLI: ./artisan package:install ArtisanCLI->>Setup: Execute setup script alt Bootstrap Setup Mode Setup->>Modify: RegisterProvider() [was AddProviderApply()] Modify->>Bootstrap: Add &minio.ServiceProvider{} Bootstrap-->>Setup: Provider registered else Traditional Setup Mode Setup->>Modify: modify.Register() Modify->>App: Add provider to app.go App-->>Setup: Provider registered end Setup->>Modify: AddImport() for minio facades Setup->>Modify: AddConfig() for minio disk Modify-->>Setup: Configuration updated Setup-->>ArtisanCLI: Installation complete ArtisanCLI-->>User: Package installed Note over Setup,Modify: API method names updated in v1.17:<br/>AddProviderApply → RegisterProvider<br/>RemoveProviderApply → UnregisterProvider