feat: [#667] Registering service providers don't dependent order - #91
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR decouples service provider registration order by introducing a Relationship method, simplifies package installation in the README, and updates several dependencies in go.mod.
- Introduced
Relationshipmethod inservice_provider.goto declare bindings, dependencies, and provisions. - Simplified installation steps in
README.mdusing an automated artisan command. - Upgraded
github.com/goravel/frameworkand various indirect dependencies ingo.mod.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| service_provider.go | Added Relationship method; renamed receivers to r for Register and Boot methods. |
| go.mod | Updated github.com/goravel/framework to v1.15.2-… and bumped carbon/v2, mapstructure/v2, and x/exp. |
| README.md | Replaced manual install steps with ./artisan package:install; updated version compatibility. |
Comments suppressed due to low confidence (2)
service_provider.go:17
- Consider adding a unit test for the new
Relationshipmethod to verify thatBindings,Dependencies, andProvideForcontain the intended values.
func (r *ServiceProvider) Relationship() binding.Relationship {
README.md:27
- Reintroduce guidance on setting
MINIO_ACCESS_KEY_ID,MINIO_ACCESS_KEY_SECRET, andMINIO_BUCKETenvironment variables or update tests to mock Minio, so users know how to satisfy test prerequisites.
Run command below to run test:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#667
This pull request includes updates to the Goravel Minio integration, enhancements to the
service_provider.gofile, and dependency version upgrades ingo.mod. The most significant changes focus on simplifying the installation process, improving service provider functionality, and updating dependencies to newer versions.Updates to Goravel Minio Integration:
README.md: Simplified the installation process by replacing manual steps with an automated command (./artisan package:install) and added a reference to the setup file for manual installation.Enhancements to Service Provider:
service_provider.go: Introduced theRelationshipmethod to define bindings, dependencies, and provisions for the Minio service provider. This improves modularity and dependency management.service_provider.go: Added thebinding.Relationshipimport to support the newRelationshipmethod.Dependency Version Upgrades:
go.mod: Updatedgithub.com/goravel/frameworktov1.15.2-0.20250701070909-51b5ee2aed12.go.mod: Upgraded indirect dependencies, includinggithub.com/dromara/carbon/v2tov2.6.9,github.com/go-viper/mapstructure/v2tov2.3.0, andgolang.org/x/exptov0.0.0-20250620022241-b7579e27df2b. [1] [2]✅ Checks