feat: support format: "hostname" in fromJSONSchema - #6305
Open
catdalfonso wants to merge 1 commit into
Open
Conversation
`fromJSONSchema` maps JSON Schema string formats onto Zod checks, but had no branch for `hostname`, so such schemas fell through to a plain string and silently accepted any value. Zod already ships `z.hostname()`, so wire it up alongside the other network formats. This also makes the conversion round-trip: `toJSONSchema()` already emits `format: "hostname"` for `z.hostname()`. Closes colinhacks#6304 Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fromJSONSchemamaps string formats onto Zod checks but had no branch forhostname, so those schemas fell through to a plain string and accepted anyvalue.
z.hostname()already exists, so this wires it up alongside the othernetwork formats.
Round-trips cleanly, since
toJSONSchema()already emitsformat: "hostname"for
z.hostname().Closes #6304