feat: serve dev schemas under their actual name - #564
Open
jo-mueller wants to merge 1 commit into
Open
Conversation
Contributor
Automated Review URLs |
Contributor
Author
|
Downloading from https://ngff--564.org.readthedocs.build/0.6rc0/schemas/image.schema works 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563
Fixes ome/ngff-spec#69
Small change to how the schemas are provided from the ngff page. In the current build, schemas are always served under a folder name that is derived from the name of the git submodule. For the dev versions, I see value in serving the (latest) schemas under both
https://ngff.openmicroscopy.org/dev/schemas/...https://ngff.openmicroscopy.org/0.9.dev17/schemas/...which would be possible through this PR.
Edit: I think this will also greatly reduce the number of warnings for the RTD build, since all the schema URLs will now correctly resolve to the ngff page, which is something @dstansby reported already a while ago (see ome/ngff-spec#69). I thought it was a json-schema-forhumans-issue, but the problem is maybe that schema URLs could not be resolved correctly since they weren't served under their actual name.
cc @lubianat