Skip to content

Update GUNC modules and enable it in test_assembly_input - #1000

Merged
dialvarezs merged 5 commits into
nf-core:devfrom
dialvarezs:update-gunc
Mar 16, 2026
Merged

Update GUNC modules and enable it in test_assembly_input#1000
dialvarezs merged 5 commits into
nf-core:devfrom
dialvarezs:update-gunc

Conversation

@dialvarezs

@dialvarezs dialvarezs commented Mar 16, 2026

Copy link
Copy Markdown
Member

GUNC 1.1.0 includes a small database for small tests, making it possible to run the tool in CI.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise look good

Comment thread tests/test_assembly_input.nf.test.snap Outdated

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass!

@dialvarezs
dialvarezs merged commit ddee3e5 into nf-core:dev Mar 16, 2026
24 checks passed
@dialvarezs dialvarezs mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants